Update gen-typescript-declarations and generate constructor types #5281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimvdLippe
requested review from
dfreedm,
kevinpschaaf and
sorvell
as code owners
aomarks
approved these changes
Jun 30, 2018
|
Travis appears to be absolutely busted. It has failed on 1. installing NPM dependencies 2. an earlier cancelled job that broke a subsequent build 3. launching Chrome with Selenium. None of these issues are related to this PR, so I am going ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes TypeScript projects using the constructors compile properly.
Reference Issue
Fixes #5189