Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure properties is only invoked once #5261

Merged
merged 3 commits into from
Aug 3, 2018
Merged

Ensure properties is only invoked once #5261

merged 3 commits into from
Aug 3, 2018

Conversation

TimvdLippe
Copy link
Contributor

The static get properties was invoked twice because of an if-guard. Instead, invoke it once and reassign to a variable and use that in the if-guard instead.

Reference Issue

Fixes #5252

@TimvdLippe TimvdLippe requested a review from dfreedm June 16, 2018 12:08
@TimvdLippe TimvdLippe mentioned this pull request Jun 16, 2018
Closed
@TimvdLippe
Copy link
Contributor Author

Test failure is in dom-repeat which seems unrelated. Not sure why this is suddenly breaking. Works just fine on master.

@TimvdLippe
Copy link
Contributor Author

This PR is ready for review again

@sorvell sorvell merged commit 59405b5 into master Aug 3, 2018
@sorvell sorvell deleted the double-properties-invocation branch August 3, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorvell sorvell sorvell approved these changes

@dfreedm dfreedm Awaiting requested review from dfreedm

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimvdLippe @sorvell @googlebot