Update template docs. #5233
Merged
Update template docs. #5233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In support of Polymer#5222, this updated the `template()` documentation so that it no longer lists support for `typeof template === 'string'` types.
Westbrook
requested review from
dfreedm,
kevinpschaaf,
sorvell and
TimvdLippe
as code owners
TimvdLippe
approved these changes
May 15, 2018
|
Note for future self: while you thought this change was harmless, do not try to be smart again and merge without Travis passing. In 3.x we do not run the typescript compilation, but if we were this would have failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of #5222, this updated the
template()documentation so that it no longer lists support fortypeof template === 'string'types.Reference PR
Follow up: #5222