Add ability to define importMeta on hybrid elements. Fixes #5163 #5180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpschaaf
requested review from
dfreedm,
sorvell and
TimvdLippe
as code owners
dfreedm
requested changes
Apr 5, 2018
lib/legacy/legacy-element-mixin.html
Outdated
| * passed to `Polymer({...})`) to the static API. | ||
| * | ||
| * @return {!Object} The `import.meta` object set on the prototype | ||
| * @suppress {missingProperties} |
There was a problem hiding this comment.
Please add reasoning.
`this` is always in the instance in closure for some reason.
|
cc @aomarks @justinfagnani Support for |
dfreedm
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change, hybrid elements defined in ES modules using legacy API can ensure a correct
importPathas follows:This change also removes the default
static get importMeta()implementation, for better compatibility with defining element metadata using (compiled) static class fields.Reference Issue
Fixes #5163