Add importMeta getter to derive importPath from modules. Fixes #5163 #5172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpschaaf
requested review from
dfreedm,
sorvell and
TimvdLippe
as code owners
TimvdLippe
approved these changes
Apr 2, 2018
lib/mixins/element-mixin.html
Outdated
| this._importPath = module ? module.assetpath : '' || | ||
| Object.getPrototypeOf(/** @type {PolymerElementConstructor}*/ (this).prototype).constructor.importPath; | ||
| if (module) { | ||
| this._importPath = module ? module.assetpath : ''; |
There was a problem hiding this comment.
Can be just module.assetpath, as the condition already asserted for module
sorvell
suggested changes
Apr 3, 2018
lib/mixins/element-mixin.html
Outdated
| @@ -409,13 +409,30 @@ | |||
| */ | |||
| static get importPath() { | |||
| if (!this.hasOwnProperty(JSCompiler_renameProperty('_importPath', this))) { | |||
| const meta = this.importMeta; | |||
| if (meta) { | |||
| this._importPath = meta.url.slice(0, meta.url.lastIndexOf('/') + 1); | |||
sorvell
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to determine the import path for ES modules, rather than implement
static get importPath()and return the folder name ofimport.meta.url, users can implement the following getter (verbatim), and Polymer will use that when defined to determine theimportPath:Reference Issue
Fixes #5163
cc: @arthurevans to roll into 3.0 docs