Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle disabled attribute correctly for tap gesture #5128

Merged
merged 1 commit into from
Feb 22, 2018
Merged

Handle disabled attribute correctly for tap gesture #5128

merged 1 commit into from
Feb 22, 2018
+121 −21

Conversation

dfreedm
Copy link
Member

@dfreedm dfreedm commented Feb 22, 2018

Fixes #4685

sorvell
sorvell approved these changes Feb 22, 2018
View reviewed changes
Copy link
Contributor

@sorvell sorvell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not completely correct since it works with any element that has a disabled property set to true and doesn't handle events bubbling to the disabled target, but seems good for satisfying the basic expectation.

@dfreedm dfreedm merged commit 438c293 into master Feb 22, 2018
@dfreedm dfreedm deleted the respect-disabled-attr branch February 22, 2018 22:40
@dmitryxcom dmitryxcom mentioned this pull request Apr 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorvell sorvell sorvell approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

@TimvdLippe TimvdLippe Awaiting requested review from TimvdLippe

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dfreedm @sorvell @googlebot