Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dispatchEvent returns boolean #5117

Merged
merged 3 commits into from
Feb 15, 2018
Merged

dispatchEvent returns boolean #5117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68f0a98
dispatchEvent returns boolean
aomarks Feb 15, 2018
4aa10b2
Update return description.
aomarks Feb 15, 2018
a0b14fb
Update typings.
aomarks Feb 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/utils/templatize.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,10 @@
* dispatch events safely no-op.
*
* @param {Event} event Event to dispatch
* @return {boolean} Always true.
*/
dispatchEvent(event) { // eslint-disable-line no-unused-vars
return true;
}
}

Expand Down
3 changes: 2 additions & 1 deletion types/lib/utils/templatize.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,9 @@ declare class TemplateInstanceBase extends
* dispatch events safely no-op.
*
* @param event Event to dispatch
* @returns Always true.
*/
dispatchEvent(event: Event|null): any;
dispatchEvent(event: Event|null): boolean;
}

declare namespace templateInfo {
Expand Down