dispatchEvent returns boolean #5117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, previously it would return undefined, which is falsy. Maybe the intention was to block events from bubbling up? Kevin or Steve probably know best. |
|
My understanding is this was only added as a stub to prevent errors so I think this is fine. |
sorvell
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in the TypeScript declarations. Since we extend both
ElementandTemplateInstanceBase, the signatures on these two interfaces need to be compatible.Element.dispatchEventreturns aboolean, butTemplateInstanceBase.dispatchEventcurrently returnsvoid.I don't really understand how this implementation of
dispatchEventis supposed to work and when it is called, so is it ok to always returntrue(meaningpreventDefault()was not called) as I have done here?https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/dispatchEvent