[1.x] Ensure template instance isn't cached on prototype. Fixes #5096 #5102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimvdLippe
approved these changes
Feb 8, 2018
sorvell
approved these changes
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templatizer was incorrectly caching the
<template>element from the first call totemplatizeon the templatizer constructor's prototype, which then leaked it but more importantly itsdataHost(plus anything else up the tree linked viadataHost). Since the templatizer constructor is cached on the_content(which is then cached in the prototypical_notesof a custom element prototype), this resulted in an arbitrary amount of dom instances being retained via the custom element prototype.This fix instead caches a "clone" of the template without any of the instance-time references like
dataHoston the cached constructor.Reference Issue
Fixes #5096