Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type declarations inadvertently referencing Polymer.Element. #5084

Merged
merged 1 commit into from
Feb 1, 2018
Merged

Fix type declarations inadvertently referencing Polymer.Element. #5084

merged 1 commit into from
Feb 1, 2018

Commits on Feb 1, 2018

  1. Fix type declarations inadvertedtly referencing Polymer.Element. 

    Polymer defines its own `Element` class, shadowing the standard global
`Element` class. This means that references to `Element` within the
`Polymer` namespace inadvertently reference `Polymer.Element`. Here we
define an alias of the global `Element`, so that we can reference it
from declarations within the `Polymer` namespace.

See microsoft/TypeScript#983 for general
discussion of this shadowing problem in TypeScript.

Fixes #5074
    @aomarks
    aomarks committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    f2aa6b9 View commit details
    Browse the repository at this point in the history