Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Polymer.version to polymer-externs #5079

Merged
merged 1 commit into from
Jan 31, 2018
Merged

Added Polymer.version to polymer-externs #5079

merged 1 commit into from
Jan 31, 2018

Conversation

mikesamuel
Copy link
Contributor

@mikesamuel mikesamuel commented Jan 31, 2018 •
edited
Loading

No description provided.

@TimvdLippe
Copy link
Contributor

I think this file is generated so we need to annotate the type in the source code instead.

@aomarks
Copy link
Member

aomarks commented Jan 31, 2018

I think this file is generated so we need to annotate the type in the source code instead.

This one is manually maintained actually, closure-types.js is the generated one.

@aomarks aomarks merged commit b52ab81 into Polymer:master Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aomarks aomarks aomarks approved these changes

@dfreedm dfreedm Awaiting requested review from dfreedm

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

@sorvell sorvell Awaiting requested review from sorvell

@TimvdLippe TimvdLippe Awaiting requested review from TimvdLippe

Assignees
No one assigned
Labels
cla: yes source: hooli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikesamuel @TimvdLippe @aomarks @googlebot