Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use containers for testing again #5070

Merged
merged 3 commits into from
Jan 30, 2018
Merged

Use containers for testing again #5070

merged 3 commits into from
Jan 30, 2018

Conversation

dfreedm
Copy link
Member

@dfreedm dfreedm commented Jan 29, 2018

Disable chrome security sandbox due to travis-ci/travis-ci#8836

Remove node module caching with the removal of package lock

Disable chrome security sandbox due to travis-ci/travis-ci#8836

Remove node module caching with the removal of package lock
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay with the containers, but I am not sure about the cache change. If I understand correctly, it checks for existence of the exact version of these npm packages. Package.lock or not, the cache should be faster and safe to use?

@dfreedm
Copy link
Member Author

dfreedm commented Jan 29, 2018

If we're not using package-lock, I'm not sure having the npm cache is a great idea. The only way the installed modules will update now is if we push updates to package.json.

But it is worthy of a bit of debate.

@TimvdLippe
Copy link
Contributor

Before npm introduced the package lock, we were using the cache as well. I don't recall any problems back then. Per https://docs.travis-ci.com/user/caching/#Things-not-to-cache Travis advises to use the cache especially for npm.

@dfreedm
Copy link
Member Author

dfreedm commented Jan 30, 2018

SGTM

@dfreedm dfreedm merged commit 5e2990e into master Jan 30, 2018
@dfreedm dfreedm deleted the use-container-again branch January 30, 2018 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants