Ensure re-sort/filter always happens after array item set. Fixes #3626 #4942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimvdLippe
approved these changes
Nov 18, 2017
| @@ -456,13 +456,19 @@ | |||
| } | |||
|
|
|||
| __handleObservedPaths(path) { | |||
| if (this.__observePaths) { | |||
There was a problem hiding this comment.
Previously the condition was only on this.__observePaths. Is there a case where this.__sortFn and this.__filterFn are both falsy, but this.__observePaths is truthy? In that case, this would regress, as the condition is no longer hit.
There was a problem hiding this comment.
According to the docs, observe (which sets __observePaths) is only relevant when using sort and/or filter so this seems ok.
lib/elements/dom-repeat.html
Outdated
| // Handle cases where path changes should cause a re-sort/filter | ||
| if (this.__sortFn || this.__filterFn) { | ||
| if (!path) { | ||
| // Always re-render if the item iteself changed |
sorvell
approved these changes
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
this.set('items.1', {...})did not cause a re-render when sorted/filtered, even if paths were observed. This fixes the bug by ensuring that changing the entire item always causes a re-sort/filter.Reference Issue
Fixes #3626
Fixes #3254
Fixes #3247