Clarify docs on target-framerate. Fixes #4897 #4941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimvdLippe
approved these changes
Nov 17, 2017
|
@davidmaxwaterman could you review this PR as well? |
arthurevans
approved these changes
Nov 17, 2017
lib/elements/dom-repeat.html
Outdated
| * fps) to target by throttling the number of instances rendered each | ||
| * frame to not exceed the budget for the target frame rate. The | ||
| * framerate is effectively the number of `requestAnimationFrame`s that | ||
| * it tries to allow to actually fire in a given second, and it targets |
There was a problem hiding this comment.
This sentence is kind of long. Maybe break sentence here: "... a given second. It does this by measuring the time between rAFs and continuously adjusting the number of items created each rAF to maintain the target framerate."
I also tried an optional rewording here to emphasize the fact that the process is ongoing rather than one-time. Totally optional if you prefer the current text.
lib/elements/dom-repeat.html
Outdated
| * framerate is effectively the number of `requestAnimationFrame`s that | ||
| * it tries to allow to actually fire in a given second, and it targets | ||
| * this by empirically measuring the time between rAF's and throttling | ||
| * up/down the number of items created each `rAF`. Setting this to a | ||
| * higher number will allow lower latency and higher throughput for |
lib/elements/dom-repeat.html
Outdated
| * higher number will allow lower latency and higher throughput for | ||
| * things like event handlers, but will result in a longer time for the | ||
| * remaining items to complete rendering. | ||
| * event handlers and other tasks, but will result in a longer time for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #4897