Polymer 1: Allow arbitrary whitespace in CSS imports #4902
Merged
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @sorvell @kevinpschaaf @mgiuffrida It would be nice if this fix can be ported to Polymer 1, so that we (in Chromium) can avoid errors like this one as well as having to add multiple comments in the code, like these. |
|
Ping. Can someone take a look? |
|
Thanks for merging. Can we spawn a release for v1.11.1 so that this fix can eventually make it in Chromium? |
|
@azakus Is this included in a released version of Polymer 1 yet? If not, are there any plans to make one? Otherwise this fix can't be leveraged in our Chromium code. |
|
No sorry, its been too long since a release was cut. I'll try to make one today! |
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Dec 22, 2017
This reverts commit aafc53d. Reason for revert: Caused style breakages, that only happen "optimize_webui = true", see crbug.com/796824 and crbug.com/796832. Original change's description: > WebUI: Break long style lines, remove addressed TODO. > > As of Polymer 1.11.2, breaking lines within style include="..." attributes is > allowed, see [1]. Removing obsolete TODOs. > > [1] Polymer/polymer#4902 > > Bug: None > Change-Id: I0156300cf60ed3d7af76ef755532b69aa0280704 > Reviewed-on: https://chromium-review.googlesource.com/833371 > Commit-Queue: Demetrios Papadopoulos <[email protected]> > Reviewed-by: Michael Giuffrida <[email protected]> > Cr-Commit-Position: refs/heads/master@{#525396} [email protected],[email protected] # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 796824,796832 Change-Id: I85b9dd80b4fe15748d2339a04400073c9fafca12 Reviewed-on: https://chromium-review.googlesource.com/840802 Reviewed-by: Demetrios Papadopoulos <[email protected]> Commit-Queue: Demetrios Papadopoulos <[email protected]> Cr-Commit-Position: refs/heads/master@{#525840}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of #4780 for Polymer 1.