Update closure annotation to support arrays for Polymer.prototype.push #4776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckysiegel
changed the title
dfreedm
approved these changes
Aug 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update closure annotation to support arrays for Polymer.prototype.push
Polymer.Prototype.push accepts a path as an argument that is then called by Polymer.Path.get.
polymer/lib/utils/path.html
Line 203 in 0b23e74
Polymer.Path.Get accepts a string or an Array for Path, so Polymer.Prototype.push should too. It works already, but the closure compilation fails.