Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting. #4771

Merged
merged 1 commit into from
Aug 4, 2017
Merged

Fix formatting. #4771

merged 1 commit into from
Aug 4, 2017

Conversation

arthurevans
Copy link

@arthurevans arthurevans commented Aug 4, 2017 •
edited
Loading

Fixes doc formatting for addPropertyEffect. Fixes Polymer/old-docs-site#2284.

Testing: set up your polymer repo for checking the docs locally:

bower install
bower install polymerelements/iron-component-page # don't ask me why this isn't installed by default
polymer analyze polymer-element.html > analysis.json
polymer serve

Browse to localhost:/components/polymer/ to see the docs.

@arthurevans arthurevans changed the title Fix formatting. Fixes #2284. Fix formatting. Aug 4, 2017
TimvdLippe
TimvdLippe approved these changes Aug 4, 2017
View reviewed changes
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup it has been fixed. We probably should add the instructions to locally view the docs and the extra dependency somewhere?

@TimvdLippe TimvdLippe merged commit eb406c7 into master Aug 4, 2017
@TimvdLippe TimvdLippe deleted the add-prop-effect-doc branch August 4, 2017 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimvdLippe TimvdLippe TimvdLippe approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arthurevans @TimvdLippe @googlebot