Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test if path exist with ghost clicks events #4703

Merged
merged 1 commit into from
Dec 21, 2017
Merged

test if path exist with ghost clicks events #4703

merged 1 commit into from
Dec 21, 2017

Conversation

eskan
Copy link

@eskan eskan commented Jun 21, 2017

This PR add a test to the path var which can be undefined on some ghost click ( cordova/IOS ) and cause double click.
this catch have been done already in 2.x
It seems many issues can be related to this, difficult to say as behavior depends on target.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@eskan
Copy link
Author

eskan commented Jun 21, 2017

update emails addresses for cla

@googlebot
Copy link

CLAs look good, thanks!

@dfreedm dfreedm self-assigned this Sep 22, 2017
@eskan
Copy link
Author

eskan commented Oct 11, 2017

Please take a look to this so very old PR .. it's simple .. it's already done in 2.0

@dfreedm dfreedm merged commit 7b6ff53 into Polymer:1.x Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants