Process paths regardless of accessor, & loop on computeLinkedPaths. #4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorvell
suggested changes
Apr 19, 2017
lib/mixins/property-effects.html
Outdated
| } | ||
| this.__dataHasPaths = true; |
There was a problem hiding this comment.
This seems broken. If there's no accessor then the value is not applied because _setPendingProperty will not actually set the value.
There was a problem hiding this comment.
Consider setting all the linked paths here and avoiding doing it in runComputedEffects.
There was a problem hiding this comment.
For paths, the only time Polymer.Path.set is required to update the value is iff it is !isPathNotification; if it is a path notification, the value is guaranteed to have already been set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4542
The
_setPendingPropertyOrPathimplementation that the publicsetleverages does not trigger_propertiesChangedif the root property being set has no accessor. Generally this is correct, except thatlinkPathscan result in triggering linked paths with accessors, but where the root property being set has none. As such,setshould always result in_propertiesChangedrunning, to match the 1.x behavior and givecomputeLinkedPathsan opportunity to run.Additionally, since
computeLinkedPathsonly did one loop over the links, if a newly generated link was subsequently linked to a path earlier in the list, it would never compute to that link. As such,computeLinkedPathswas moved torunComputedEffectsand takes advantage of the same while loop that runs until no more pending properties are generated.