Use _importPath in resolveUrl so it available early. Fixes #4532
#4533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpschaaf
force-pushed
the
4532-kschaaf-resolve-url
branch
from
a08545c
to
1a7d3b1
Compare
|
CLAs look good, thanks! |
sorvell
reviewed
Apr 14, 2017
| @@ -138,6 +147,13 @@ | |||
| assert.equal(el.$.hash.getAttribute('href'), '#foo.z', 'hash-only url should not be resolved'); | |||
| assert.equal(el.$.absolute.getAttribute('href'), '/foo.z', 'absolute urls should not be resolved'); | |||
| assert.equal(el.$.protocol.getAttribute('href'), 'data:foo.z', 'urls with other protocols should not be resolved'); | |||
| el.$.if.render(); | |||
There was a problem hiding this comment.
Would be an improvement to fix the rx to help ensure the url is fully resolved correctly and not just that it contains the sub folder.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
_importPathinresolveUrlso it available early. Fixes #4532