Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read properties off of proto during configuration. #4314

Merged
merged 4 commits into from
Feb 22, 2017
Merged

Conversation

kevinpschaaf
Copy link
Member

Fix for UC browser, which has non-spec properties property on instances.

@kevinpschaaf kevinpschaaf changed the title Read properties off of photo during configuration. Read properties off of proto during configuration. Feb 16, 2017
Copy link
Contributor

@sorvell sorvell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's add a comment that this is a special UC browser specific fix.

@sorvell sorvell merged commit fe535a2 into master Feb 22, 2017
@sorvell sorvell deleted the 1.x-uc-browser-fix branch February 22, 2017 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants