Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 preview: extending templates #4099

Closed
wants to merge 12 commits into from

Conversation

mkazlauskas
Copy link

@mkazlauskas mkazlauskas commented Oct 26, 2016

  • Fixes a bug with extended templates, where both base and super class has bind listeners (both reference the same existing listeners array). When a super class template is parsed it would add new bind listeners to base class, referencing nodes that do not exist in base class template.
  • Adds basic tests for extending element's template.

Steps to reproduce:

  1. Pull my fork
  2. Comment out line 169 in src/elements/element.html
  3. $ wct test/unit/polymer.element.html

If a superclass with a modified (extended) template adds additional bind-listeners, they would also apply for base class. This commit fixes it.
@mkazlauskas mkazlauskas changed the title 2.0 preview 2.0 preview: extending templates Oct 31, 2016
@mkazlauskas
Copy link
Author

I've tested latest 2.0-preview commit and this PR is still relevant.

@sorvell
Copy link
Contributor

sorvell commented Apr 4, 2017

Closed in favor of #4493.

@sorvell sorvell closed this Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants