g-overlay: refactor/simplify #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sorvell
commented
Oct 29, 2012
sorvell
commented
- rename 'showing' property to 'opened'
- simplify event listeners
- style animations based on 'opened' and 'animating' attributes
- add beginnings of library of open/close animations
- rename 'showing' property to 'opened' - simplify event listeners - style animations based on 'opened' and 'animating' attributes - add beginnings of library of open/close animations
|
lgtm |
frankiefu
added a commit
that referenced
this pull request
Oct 29, 2012
…060229b g-overlay: refactor/simplify
nevir
pushed a commit
to nevir/polymer
that referenced
this pull request
Oct 31, 2014
dfreedm
pushed a commit
that referenced
this pull request
Sep 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.