Fix dynamic insertion of wrapped or redistributing content. #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // <content>'s host (1) will cause the parent to distribute as well (2) | ||
| var host; | ||
| if (isContent || hasContent) { | ||
| host = this._ownerShadyRootForNode(parent).host; |
There was a problem hiding this comment.
it's possible we don't have an owner root here isn't it?
kevinpschaaf
force-pushed
the
1631-kschaaf
branch
from
67a01d7
to
17ad90f
Compare
|
LGTM |
sorvell
pushed a commit
that referenced
this pull request
Jun 12, 2015
Fix dynamic insertion of wrapped or redistributing content.
ghost
mentioned this pull request
|
I found that when using a dom-bind template its still failing (dom-if present or not). http://jsbin.com/vifodowilu/edit?html,output <template id="main" is="dom-bind">
<test-elem2 id="foo">
<div>Hello, World!</div>
</test-elem2>
</template> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1631.
Fixes #1753.
Fixes #1800.