Handle NaN correctly in bindings #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfreedm
force-pushed
the
handle-nan-in-bindings
branch
from
c85a2df
to
8a964ba
Compare
| // NaN is always not equal to itself, | ||
| // if old and value are both NaN we treat them as equal | ||
| // x !== x is 10x faster, and equivalent to isNaN(x) | ||
| if (old !== value && !(old !== old && value !== value)) { |
There was a problem hiding this comment.
Seems like (old !== value && (old==old || value==value)) is slightly more readable.
dfreedm
force-pushed
the
handle-nan-in-bindings
branch
from
8a964ba
to
dcb67ed
Compare
Make our own equality check for NaN that uses the identity-check failure Fixes #1799
dfreedm
force-pushed
the
handle-nan-in-bindings
branch
from
dcb67ed
to
48edb32
Compare
|
Tests are passing in VMs, not sure what is going on in Sauce. |
|
LGTM, confirmed min perf impact |
kevinpschaaf
added a commit
that referenced
this pull request
Jun 11, 2015
Handle NaN correctly in bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1799