Re-insert rows when re-attaching. Fixes #1498. Fixes #1714. #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpschaaf
force-pushed
the
1498-kschaaf
branch
from
da2c5f7
to
4c1e637
Compare
kevinpschaaf
force-pushed
the
1498-kschaaf
branch
from
4c1e637
to
c2eb14e
Compare
This was referenced Jun 4, 2015
kevinpschaaf
changed the title
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this fix suffers from the same problem as
dom-bind(anddom-if) on polyfill, in that the user must manually doremove,CustomElements.takeRecords(),appendwhen moving in order for the element to actually be notified viaattachedof its change in DOM position (see webcomponents/webcomponentsjs#311). May need to consider another approach for detecting movement.