Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused keyCodes enum #1564

Merged
merged 1 commit into from
May 26, 2015
Merged

Remove unused keyCodes enum #1564

merged 1 commit into from
May 26, 2015

Conversation

jklein24
Copy link
Contributor

This depends on PolymerElements/iron-behaviors#11 which removes the only usage of this enum.

@cdata
Copy link
Contributor

cdata commented May 20, 2015

@jklein24 is this PR still relevant?

@jklein24
Copy link
Contributor Author

Yep, we still don't need this enum.

@jklein24 jklein24 assigned sjmiles and unassigned cdata May 20, 2015
@kevinpschaaf
Copy link
Member

@sjmiles do you still need keyCodes?

@dfreedm dfreedm mentioned this pull request May 26, 2015
Closed
@dfreedm
Copy link
Member

dfreedm commented May 26, 2015

Got the LGTM from @sjmiles

@dfreedm dfreedm merged commit e1d7b0b into Polymer:master May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sjmiles sjmiles

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jklein24 @cdata @kevinpschaaf @dfreedm @sjmiles @googlebot