Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8 x style #1482

Merged
merged 9 commits into from
May 4, 2015
Merged

0.8 x style #1482

merged 9 commits into from
May 4, 2015

Conversation

sorvell
Copy link
Contributor

@sorvell sorvell commented May 4, 2015

  • rename x-style --> custom-style

  • rename mixin --> @apply

  • support :root selector

  • variable defaultsvar(--a, red)

  • fixes bug: c--foo: is seen as a custom property

  • consume variable, mixin inside mixin

    --foo: {
      color: var(--my-color);
      @apply(--my-theme);
    };
  • consume custom properties in custom-style (short-term workaround to support @extend-use case style sharing

sorvell and others added 8 commits April 29, 2015 15:20
* custom properties supports defaults, e.g. var(--a, --b);
* x-style renamed to custom-style
* custom-style supports defining properties at :root; also support using properties in document
* mixins support consuming properties and mixins inside them.
@kevinpschaaf
Copy link
Member

LGTM. More optimizations and refactoring discussed for future commits.

kevinpschaaf added a commit that referenced this pull request May 4, 2015
@kevinpschaaf kevinpschaaf merged commit 1976ad0 into 0.8-preview May 4, 2015
@kevinpschaaf kevinpschaaf deleted the 0.8-x-style branch May 4, 2015 22:24
@arthurevans
Copy link

What's a :root when it's at home?

@sorvell
Copy link
Contributor Author

sorvell commented May 5, 2015

We'll add info to the primer.

It's just this (http://www.w3schools.com/cssref/sel_root.asp) and it's a
way to define custom properties for the entire root scope (where previous
we used '*')

On Mon, May 4, 2015 at 5:05 PM, Arthur Evans [email protected]
wrote:

What's a :root when it's at home?


Reply to this email directly or view it on GitHub
#1482 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants