0.8 patching #1462
Merged
0.8 patching #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fore, removeChild
| if (this.node.nodeType === Node.TEXT_NODE) { | ||
| return this.node.textContent; | ||
| } else { | ||
| return Array.prototype.map.call(this.childNodes, function(c) { |
There was a problem hiding this comment.
this.childNodes -> Polymer.dom(this).childNodes
There was a problem hiding this comment.
The calling context is Polymer.dom, so this is correct.
| @@ -349,6 +350,13 @@ | |||
| var nativeRemoveChild = Element.prototype.removeChild; | |||
|
|
|||
| function insertBefore(parentNode, newChild, refChild) { | |||
| if (newChild.nodeType === Node.DOCUMENT_FRAGMENT_NODE) { | |||
| console.log(parentNode, newChild, refChild); | |||
|
@kevinpschaaf PTAL |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional accessors to Polymer.dom: first/last child/ElementChild, previous/next sibling/ElementSibling, textContent, innerHTML
Adds experimental
patch-dom.htmlimport which patches dom that interacts with Shady DOM such that normal dom tree traversal and mutation api's can be used. This can enhance interoperation with 3rd party code that is not aware of Polymer.dom.