Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8 property config #1256

Merged
merged 10 commits into from
Mar 5, 2015
Merged

0.8 property config #1256

merged 10 commits into from
Mar 5, 2015

Conversation

kevinpschaaf
Copy link
Member

  • Renames published configuration object to properties
    • Adds computed field to properties. Replaces use of general computed object
    • Adds observer field to properties. Replaces use of general bind block for single-property observers
    • Adds value field to properties. Each property in properties accepts a value field to define a default value; may either be a static value or function that returns a value (e.g. for initializing objects/arrays); replaces use of general configure function (although general function still exists for exotic use cases)
  • Removes general computed configuration object (these must move to properties per property)
  • Renames bind to observers (general observers configuration object remains for path and multiple-dependency observers; will still work for single-property observers, although these should generally go in properties)
  • Adds multiple-dependency observer support to general observers object
  • Fixes attribute deserialization loop when setting reflect: true properties
  • Adds attribute deserialization tests

Minimal element changes required for compatibility with this API update:

  • Rename published to properties
  • Move all computed properties into properties object
  • Rename bind to observers

Not strictly required, but should update to match style going forward:

  • Move all single-property observers (formerly bind) into observer field of properties object
  • Move all default values defined in configure to value field of properties object (and remove configure function)

@@ -0,0 +1,159 @@
<script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this file.

@sorvell
Copy link
Contributor

sorvell commented Mar 5, 2015

LGTM with minor comments.

kevinpschaaf added a commit that referenced this pull request Mar 5, 2015
@kevinpschaaf kevinpschaaf merged commit 42477e4 into 0.8-preview Mar 5, 2015
@kevinpschaaf kevinpschaaf deleted the 0.8-property-config branch March 5, 2015 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants