-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.8 property config #1256
Merged
Merged
0.8 property config #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: PRIMER.md
@@ -0,0 +1,159 @@ | |||
<script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete this file.
LGTM with minor comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
published
configuration object toproperties
computed
field toproperties
. Replaces use of generalcomputed
objectobserver
field toproperties
. Replaces use of generalbind
block for single-property observersvalue
field toproperties
. Each property inproperties
accepts avalue
field to define a default value; may either be a static value or function that returns a value (e.g. for initializing objects/arrays); replaces use of generalconfigure
function (although general function still exists for exotic use cases)computed
configuration object (these must move toproperties
per property)bind
toobservers
(generalobservers
configuration object remains for path and multiple-dependency observers; will still work for single-property observers, although these should generally go inproperties
)observers
objectreflect: true
propertiesMinimal element changes required for compatibility with this API update:
published
toproperties
computed
properties intoproperties
objectbind
toobservers
Not strictly required, but should update to match style going forward:
observers
(formerlybind
) intoobserver
field ofproperties
objectconfigure
tovalue
field ofproperties
object (and removeconfigure
function)