Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed insertion of numbers and booleans in the weakmap in 0.8-preview #1253

Merged
merged 1 commit into from
Mar 20, 2015

Conversation

cedric-marcone
Copy link
Contributor

I stumbled on this bug while trying to render numbers or booleans in 0.8-preview.

It works perfectly when the property is an array of objects or strings.

The error is : "Uncaught TypeError: Invalid value used as weak map key" and can be tracked down to lib/collection.html a line 49.

To reproduce :

<dom-module id="x-component">
  <template>
    <template is="x-repeat" items="{{values}}">
      <span>{{item}}</span>
    </template>
  </template>
</dom-module>
<script>
Polymer({
  is: 'x-component',
  ready: function() {
    this.values = [ 1, 2, 3 ];
  }
});
</script>

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@cedric-marcone
Copy link
Contributor Author

CLA signed

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Mar 4, 2015
@sorvell sorvell added 0.8 and removed 0.8 labels Mar 5, 2015
@kevinpschaaf kevinpschaaf merged commit 7659d0b into Polymer:0.8-preview Mar 20, 2015
@kevinpschaaf
Copy link
Member

Thanks!

@cedric-marcone cedric-marcone deleted the 0.8-preview branch March 23, 2015 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants