Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolkit Components fail if they have a property named "node" #78

Closed
dfreedm opened this issue Mar 20, 2013 · 1 comment
Closed

Toolkit Components fail if they have a property named "node" #78

dfreedm opened this issue Mar 20, 2013 · 1 comment
Assignees
@sjmiles
Labels
bug

Comments

@dfreedm
Copy link
Member

dfreedm commented Mar 20, 2013

Because of the workaround for toolkitchen/ShadowDOM#27, any toolkit component with a property named "node" will cause bindNodeModel in bindMDV to fail.

Particularly bad is if node = ancestor of element being processed, which will cause an infinite loop.
@ghost ghost assigned sjmiles Mar 20, 2013
@sjmiles
Copy link
Contributor

sjmiles commented Mar 20, 2013

It's a lazy conditional, my bad.

@dfreedm dfreedm closed this as completed Apr 16, 2013
dfreedm pushed a commit that referenced this issue Sep 9, 2016
Merge pull request #78 from PolymerLabs/template-subclass
ed01601 
Template subclass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjmiles sjmiles

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dfreedm @sjmiles