Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not a BUG - FYI: Update tutorial - core-icon-button #730

Closed
migueltt opened this issue Aug 27, 2014 · 2 comments
Closed

Not a BUG - FYI: Update tutorial - core-icon-button #730

migueltt opened this issue Aug 27, 2014 · 2 comments

Comments

@migueltt
Copy link

NOT A BUG - Just an FYI

In http://www.polymer-project.org/docs/start/tutorial/step-4.html#edit-post-cardhtml, there are instructions to add styling for the post-card.html file that includes "fill" attributes to change color whenever the "favorite" button is clicked.
It must say "color" instead:

CURRENT:

core-icon-button {
  position: absolute;
  top: 3px;
  right: 3px;
  fill: #636363;
}
:host([favorite]) core-icon-button {
  fill: #da4336;
}

IT MUST BE:

core-icon-button {
  position: absolute;
  top: 3px;
  right: 3px;
  color: #636363;
}
:host([favorite]) core-icon-button {
  color: #da4336;
}

Also, the polymer files distributed within the tutorial should be updated with the latest version distributed in github.

@tjsavage
Copy link
Contributor

tjsavage commented Sep 2, 2014

auto-moving this issue to Polymer/old-docs-site#631 and closing this one

@tjsavage tjsavage closed this as completed Sep 2, 2014
@tjsavage
Copy link
Contributor

tjsavage commented Sep 2, 2014

Thanks for the note! Adding this issue to the Polymer/docs repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants