Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stoped to render on firefox after .35 update (trying to fix jquery conflict) #697

Closed
ronybarbosa opened this issue Aug 9, 2014 · 8 comments
Assignees

Comments

@ronybarbosa
Copy link

Hi Guys,

I updated yestarday to the 0.35 release trying to fix the problem with getDefaultComputedStyle error with jquery on firefox.

But after this update my test app has stopped to render on Firefox. Its rendering only on IE and Chrome

You can check my test app here:

http://widget.centraltorpedos.com.br/gmaps/

Another problem is that, the getDefaultComputedStyle error was solved for jquery 1.10.02. But if you use the newest jquery version (1.11.1) implementation, this issue still happens .

@jmesserly jmesserly added the p1 label Aug 19, 2014
@tjsavage tjsavage added this to the beta milestone Aug 21, 2014
@jmesserly
Copy link
Contributor

hmmm. Debugging this a bit, it seems to end up with a Shadow DOM wrapper node, but that wrapper has no impl property so it blows up. Is it possible that something is deleting .impl?

Unfortunately ... I can't even tell what the node is at that point because all DOM calls on it blow up (since there's no impl node)... going up the stack, it seems to be a "post-service". Though if I create one with document.createElement it's wrapped correctly.

One interesting thing: the name of the failing attribute is "properties". That makes me think it might be colliding with an experimental API (recently added?) in firefox:
https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement

Such a collision could very well send the code a bit haywire. For better or worse, overriding native properties is not well supported by browsers.

@jmesserly jmesserly removed the p1 label Aug 29, 2014
@jmesserly
Copy link
Contributor

hmmm, though now it makes me wonder why I'm not seeing the same problem you were. for me the example failed before I got to getDefaultComputedStyle. I'm testing Firefox 32 (beta).

in your Firefox, if you do document.body.properties at the console, do you get an HTMLPropertiesCollection?

@ronybarbosa
Copy link
Author

Nice tip!

I have changed the name of this variable for propertyset and now its working on firefox =D
So probably is a variable name conflict.

Its still not working on safari. how is the compatibility of polymer with safary ?

@jmesserly
Copy link
Contributor

Hmmm, when I tried it yesterday and again today it worked for me on Safari. I'm using 7.0.6
edit: great to hear it's working on firefox now!

@ronybarbosa
Copy link
Author

Hmmmm.. I was testing on Safari 5 (the only version available for windows).

I will trust on you so. I don't have an apple machine to test it.

The only issue here was the variable name conflict on Firefox.

@robdodson
Copy link
Contributor

We don't support Safari 5 on Windows because it's been discontinued. The
earliest version of Safari we support is, I believe, Safari 6 on Mac.

On Fri, Aug 29, 2014 at 7:48 PM, ronydj [email protected] wrote:

Hmmmm.. I was testing on Safari 5 (the only version available for windows).

I will trust on you so. I don't have an apple machine to test it.

The only issue here was the variable name conflict on Firefox.


Reply to this email directly or view it on GitHub
#697 (comment).

@nazar-pc
Copy link
Contributor

nazar-pc commented Jan 6, 2015

@ronydj, there was bug in jQuery and I fixed it, currently it is available in latest stable jQuery version. Is this still an issue or can be closed?

@ronybarbosa
Copy link
Author

thanks Nazar. It can be closed.

att,

Rony Barbosa Tomaz

Computer Engineer
Universidade Federal de Goiás
+55 62 9135 86 49 (Goiânia- Goiás)


On Tue, Jan 6, 2015 at 2:22 PM, Nazar Mokrynskyi [email protected]
wrote:

@ronydj https://github.com/ronydj, there was bug in jQuery and I fixed
it, currently it is available in latest stable jQuery version. Is this
still an issue or can be closed?


Reply to this email directly or view it on GitHub
#697 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants