Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on-change event triggered twice #687

Closed
gaplyk opened this issue Aug 5, 2014 · 4 comments
Closed

on-change event triggered twice #687

gaplyk opened this issue Aug 5, 2014 · 4 comments
Assignees

Comments

@gaplyk
Copy link

gaplyk commented Aug 5, 2014

http://jsbin.com/bodelite/1/edit

After input value changed we receive 2 events CustomEvent and Event "change". Is this is an issue or it should behave like this?

@ebidel
Copy link
Contributor

ebidel commented Aug 8, 2014

According to the Shadow DOM spec, the change event is supposed to stop at the root of the node tree.

core-input accounts for this by firing a CustomEvent for change: https://github.com/Polymer/core-input/blob/master/core-input.html#L331:L334

However, what I'm seeing from native SD is the the original change is actually bubbling up: http://jsbin.com/zimatace/1/edit. Is that expected?

Assigning to @sorvell for clarification.

@frankiefu
Copy link
Member

@gaplyk
Copy link
Author

gaplyk commented Aug 8, 2014

here is full example:

http://jsbin.com/bodelite/4/edit

@tjsavage
Copy link
Contributor

Good catch! Closing here since it's a native SD bug, looking to be fixed in the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants