Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core-toolbar breaking material design speck #605

Closed
mirceapiturca opened this issue Jul 5, 2014 · 1 comment
Closed

Core-toolbar breaking material design speck #605

mirceapiturca opened this issue Jul 5, 2014 · 1 comment

Comments

@mirceapiturca
Copy link

Core toolbar component from:
http://www.polymer-project.org/components/paper-elements/demo.html#core-toolbar
does not align with the grid mentioned at:
http://www.google.com/design/spec/layout/metrics-and-keylines.html#metrics-and-keylines-keylines-and-spacing

According to the speck on mobile devices: "Vertical keyline at 16 dp from the left and right edges. Content associated with an icon or avatar aligns 72 dp from the left edge. 16 dp horizontal margins on mobile." See image: http://material-design.storage.googleapis.com/images/layout-metrics-keylines-keylines-spacing-mobile-01bb_large_mdpi.png
On tablet the padding to the first menu icon should be of 24 dp: http://material-design.storage.googleapis.com/images/layout-metrics-keylines-keylines-spacing-tablet-01a_large_mdpi.png

Current component have fixed margins regardless on screen size.

The speck does not really define what a mobile or tablet resolution is, with today's devices is hard to tell witch is witch but I do believe that a mediaquery should define few breakpoints.

Thank you.

@tjsavage
Copy link
Contributor

tjsavage commented Aug 1, 2014

auto-moving this issue to googlearchive/core-toolbar#7 and closing this one

@tjsavage tjsavage closed this as completed Aug 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants