Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake on proto-element.html #602

Closed
ghost opened this issue Jul 4, 2014 · 2 comments
Closed

Mistake on proto-element.html #602

ghost opened this issue Jul 4, 2014 · 2 comments

Comments

@ghost
Copy link

ghost commented Jul 4, 2014

http://www.polymer-project.org/docs/start/creatingelements.html

Ctrl + F for "proto-element" and look at the tag for proto-element.html

href="/components/polymer/polymer.html

Shouldn't it be href = "/bower_components/polymer/polymer.html"?

@ghost ghost changed the title You guys have a mistake on proto-element.html Mistake on proto-element.html Jul 4, 2014
@sjmiles
Copy link
Contributor

sjmiles commented Jul 4, 2014

Bower by default creates bower_components, but this can be changed with arguments or with a .bowerrc file.

IMO, since components can be acquired from various sources (.ZIP files, git checkouts, other package delivery tools, local folders), I prefer to simply call the folder components.

Since rest of the tutorial is using bower_components, you are right that there is a real problem here. I'm just explaining why components can creep in. If I had my way, we would always use components. =P

@ebidel
Copy link
Contributor

ebidel commented Jul 5, 2014

In addition...the site uses the pull-all.sh script to suck in all of Polymer's components (so we avoid Bower altogether). That script is configured to stick things in "components". See https://github.com/Polymer/tools/blob/master/repo-configs/core.json#L3.

Closing this as it's not an actual bug.

@ebidel ebidel closed this as completed Jul 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants