Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Duplication: unnecessary core-icon-button declaration block to style the fill color of the favorite icon #570

Closed
lozandier opened this issue Jun 28, 2014 · 0 comments

Comments

@lozandier
Copy link

For some reason, two declarations blocks were used to style core-icon-button instead of one. If there was an explicit reason for this, it remained unaddressed.

If I'm correct there wasn't a strong reason for the second declaration block, it may be better to have the style code snippet presented similar to the code snippet below this paragraph:

 core-icon-button {
    position: absolute;
    top: 3px;
    right: 3px;
    fill: #636363;
  }

  :host([favorite]) core-icon-button {
    fill: #da4336;
 }
robdodson added a commit to Polymer/old-docs-site that referenced this issue Jun 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant