Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polymer.dom(event).localTarget returns incorrect target with ShadyDOM.noPatch on #5526

Closed
sorvell opened this issue Apr 22, 2019 · 0 comments · Fixed by #5527
Closed

Polymer.dom(event).localTarget returns incorrect target with ShadyDOM.noPatch on #5526

sorvell opened this issue Apr 22, 2019 · 0 comments · Fixed by #5527
Assignees
@sorvell

Comments

@sorvell
Copy link
Contributor

sorvell commented Apr 22, 2019

The intention of Polymer.dom(event).localTarget is to return the lowest element in the same root as the event's currentTarget. When ShadyDOM.noPatch is enabled, we just return currentTarget, which is incorrect.
@sorvell sorvell self-assigned this Apr 22, 2019
sorvell pushed a commit that referenced this issue Apr 22, 2019
Fix localTareget when ShadyDOM.noPatch is in use
7925254 
Fixes #5526.

Return the "lowest" element in the same root as the node listening for the event (currentTarget).
@sorvell sorvell mentioned this issue Apr 22, 2019
Merged
dfreedm pushed a commit that referenced this issue Apr 22, 2019
@dfreedm
Fix localTareget when ShadyDOM.noPatch is in use
97334bf 
Fixes #5526.

Return the "lowest" element in the same root as the node listening for the event (currentTarget).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix localTarget when ShadyDOM.noPatch is in use Polymer/polymer
1 participant
@sorvell