Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bower_components is published to npm. #5244

Closed
coreyfarrell opened this issue May 28, 2018 · 2 comments
Closed

bower_components is published to npm. #5244

coreyfarrell opened this issue May 28, 2018 · 2 comments

Comments

@coreyfarrell
Copy link
Contributor

Description

After running npm install @polymer/polymer you get everything from polymer 2 into node_modules/@polymer/polymer/bower_components/.

Steps to Reproduce

  1. Execute npm install @polymer/polymer

Expected Results

node_modules/@polymer/polymer should not contain bower_components.

Actual Results

node_modules/@polymer/polymer is 16MB. Of that 14MB is bower_components (polymer-2). In addition a dist folder is included which appears to be from polymer 2.

Versions

  • Polymer: v3.0.2
@TimvdLippe
Copy link
Contributor

Ah, we missed that one in #5215 Feel free to publish a PR that would add such folders to .npmignore! (I think you can actually copy-paste all from .gitignore into this file)

@coreyfarrell coreyfarrell mentioned this issue May 28, 2018
Merged
@abdonrd
Copy link
Contributor

abdonrd commented May 28, 2018 •
edited
Loading

@TimvdLippe WDYT about use the files option as webcomponents/webcomponentsjs#929?

Right now: https://unpkg.com/@polymer/[email protected]/

We can add it as:

  "files": [
    "externs/**/*",
    "lib/**/*",
    "polymer-element.js",
    "polymer-legacy.js"
  ]

TimvdLippe pushed a commit that referenced this issue May 30, 2018
@coreyfarrell @TimvdLippe
Replace .npmignore with package.json "files" option. (#5245)
eb84ea0 
This effectively removes the following from the NPM packages:
* bower_components
* dist
* CONTRIBUTING.md
* gen-tsd.json
* gulpfile.js
* wct.conf.json

Fixes #5244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@coreyfarrell @abdonrd @TimvdLippe