Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generate-externs for module compatibility in 3.x #5212

Closed
kevinpschaaf opened this issue Apr 30, 2018 · 0 comments · Fixed by #5360
Closed

Fix generate-externs for module compatibility in 3.x #5212

kevinpschaaf opened this issue Apr 30, 2018 · 0 comments · Fixed by #5360
Assignees
@dfreedm
Labels
3.x p1 tools

Comments

@kevinpschaaf
Copy link
Member

Description

gulp generate-externs currently outputs a bad externs file, and needs to be updated to work with Polymer 3.x's module-based source.

Steps to Reproduce

gulp generate-externs

Expected Results

No errors, outputs correct externs.

Actual Results

Externs file is tiny and contains lots of undefined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfreedm dfreedm

Labels
3.x p1 tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update gen-closure-declarations to 0.5.0 Polymer/polymer
3 participants
@dfreedm @kevinpschaaf @TimvdLippe