Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript definitions for Polymer.FlattenedNodesObserver do not have constructor #5189

Closed
eterna2 opened this issue Apr 12, 2018 · 3 comments

Comments

@eterna2
Copy link

eterna2 commented Apr 12, 2018

Description

The typescript definitions for Polymer.FlattenedNodesObserver for Polymer do not have a constructor defined when arguments are expected. This cause typescript to incorrectly flag the error expected 0 arguments but got 2 . when creating a new instance of FlattenedNodesObserver.

Steps to Reproduce

  1. Create a instance of FlattenedNodesObserver
this._observer = new Polymer.FlattenedNodesObserver(this, (info: any) => {
   this.info = info;
});

Expected Results

No error flagged.

Actual Results

expected 0 arguments but got 2 . error flagged.

Versions

  • Polymer: v2.6.0
  • Typescript: 2.8.1
@TimvdLippe
Copy link
Contributor

This is pending a release of https://github.com/Polymer/gen-typescript-declarations @aomarks could you make a release for that? Then I can make the update here in this repo.

@aomarks
Copy link
Member

aomarks commented Jun 29, 2018

This is pending a release of https://github.com/Polymer/gen-typescript-declarations @aomarks could you make a release for that? Then I can make the update here in this repo.

Published @polymer/[email protected]

@TimvdLippe
Copy link
Contributor

Fixed in #5281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants