Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:dir support for 1.x and native ShadowDOM 2.x #4860

Closed
dfreedm opened this issue Oct 3, 2017 · 1 comment
Closed

:dir support for 1.x and native ShadowDOM 2.x #4860

dfreedm opened this issue Oct 3, 2017 · 1 comment
Assignees
@dfreedm
Labels
1.x 1.x-2.x compatibility 2.x p1 source: hooli

Comments

@dfreedm
Copy link
Member

dfreedm commented Oct 3, 2017

ShadyCSS supports :dir() to provide different styling for RTL and LTR layouts.
This should be backported to 1.x, and also polyfilled to be supported in Native ShadowDOM for 2.x.

The approach for 2.x is somewhat simple: With a mixin, we can detect the direction of the page and set an attribute on all elements implementing the mixin. Then, we can transform :dir() into a simple attribute selector.
@dfreedm dfreedm self-assigned this Oct 3, 2017
dfreedm added a commit that referenced this issue Oct 5, 2017
@dfreedm
First draft of a :dir aware element mixin
2ef65aa 
Related to #4860
@dfreedm dfreedm mentioned this issue Oct 11, 2017
Merged
dfreedm added a commit that referenced this issue Oct 11, 2017
@dfreedm
Add :dir support to Polymer 1
ae37f83 
Polymer 1.x fix for #4860

`:dir` becomes `:host-context([dir])`
@dfreedm dfreedm mentioned this issue Oct 11, 2017
Merged
@dfreedm
Copy link
Member Author

dfreedm commented Oct 16, 2017

Fixed with #4880 and #4881

@dfreedm dfreedm closed this as completed Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfreedm dfreedm

Labels
1.x 1.x-2.x compatibility 2.x p1 source: hooli
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dfreedm