Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Consider renaming polymer.js #4805

Closed
justinfagnani opened this issue Aug 23, 2017 · 7 comments
Closed

[3.0] Consider renaming polymer.js #4805

justinfagnani opened this issue Aug 23, 2017 · 7 comments

Comments

@justinfagnani
Copy link
Contributor

The file /polymer.html was named so for backwards compatibility with Polymer 1.0, so that hybrid elements could use the same import. We don't have this constraint with 3.0, and could rename polymer.js to polymer-legacy.js, which would allow us to create a new polymer.js with only modern exports.

@joeblew99
Copy link

Why break everyone that need to stick with polymer 1 - 2 for a fair while ?
Instead use a new name for polymer 3.0. maybe polymer 3.js

@arthurevans
Copy link

This change--if we make it--wouldn't affect 1.x or 2.x at all--they import an html file, not a js file. You'll need to change how you import polymer when you go from 2 to 3 whether or not we make this change.

@joeblew99
Copy link

ah i missed the .html and .js. Makes sense now. thanks @arthurevans

@baocang
Copy link

baocang commented Aug 29, 2017

Move backwards compatibility version to -legacy is better. I like always keep polymer.html|js as modern.

@justinfagnani
Copy link
Contributor Author

If we choose to do this, we can do it one of two ways: Hard-code a filename remapping in polymer-modulizer, or add the ability to make a directive in a file to have modulizer rename it:

ie, in polymer-element.html:

<!-- modulizer-rename: polymer.js -->

@bicknellr
Copy link
Member

(Blocked on Polymer/polymer-modulizer#354.)

@bicknellr
Copy link
Member

#367 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants