Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all listeners for scroll events added with passive option #4702

Closed
1 task
dhrytsenko opened this issue Jun 20, 2017 · 1 comment
Closed
1 task

Not all listeners for scroll events added with passive option #4702

dhrytsenko opened this issue Jun 20, 2017 · 1 comment
Assignees
@dfreedm
Labels
2.x p1

Comments

@dhrytsenko
Copy link

Description

l work on PWA build with Polymer 2 and try to check it performance and other stuff with Lighthouse. I got one error about scroll listeners: Uses passive listeners to improve scrolling performance on line 434 in /polymer/lib/utils/gestures.html file.
l saw that you already added passive listeners for scroll event but I think you missed few listeners which added without {passive: true} option for event like touchstart and touchend in _add function. Can you fix it?

Example

Lighthouse result

Browsers Affected

  • Chrome

Versions

  • Polymer: v2.0.1
@dfreedm
Copy link
Member

dfreedm commented Jun 22, 2017

Dupe of #4667

@dfreedm dfreedm closed this as completed Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfreedm dfreedm

Labels
2.x p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dfreedm @sorvell @dhrytsenko