Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dom-repeat.itemsIndexAs documentation might be incorrect #4554

Closed
mattpalermo opened this issue Apr 20, 2017 · 2 comments
Closed

dom-repeat.itemsIndexAs documentation might be incorrect #4554

mattpalermo opened this issue Apr 20, 2017 · 2 comments

Comments

@mattpalermo
Copy link

Description

Documentation for dom-repeat.itemsIndexAs is exactly the same as dom-repeat.indexAs. I suspect that the dom-repeat.itemsIndexAs documentation should say things which are "opposite" to the dom-repeat.indexAs documentation.

Possible fix

        /**
         * The name of the variable to add to the binding scope with the index
         * for the item. If `sort` or `filter` is provided, the item index will reflect the
         * original array order (rather than the sorted and filtered order).
         */

Versions

Current master

@arthurevans
Copy link

From what I can see, it looks like the fix proposed by @mattpalermo is correct ... @kevinpschaaf?

sorvell pushed a commit that referenced this issue Apr 21, 2017
@kevinpschaaf
Copy link
Member

Thanks! Fixed in #4557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants