Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid usage of dom-bind stamps content in different places in 1.x and 2.x. #4536

Closed
bicknellr opened this issue Apr 15, 2017 · 1 comment
Closed

Comments

@bicknellr
Copy link
Member

In hybrid code, dom-bind (and others) have to be written as a combination of both wrapper and is= form:

<dom-bind>
  <template is="dom-bind">
    <some-element></some-element>
  </template>
</dom-bind>

In 1.x, the content ends up stamped like this:

<dom-bind>
  <some-element></some-element> <!-- content stamped here -->
  <template is="dom-bind">
    <some-element></some-element>
  </template>
</dom-bind>

But in 2.x, the content is stamped like this:

<some-element></some-element> <!-- content stamped here -->
<dom-bind>
  <template is="dom-bind">
    <some-element></some-element>
  </template>
</dom-bind>

This can be a problem if the content depends on looking at the tree it's inserted in, such as IronFitBehavior.

Expected Results

The content of the dom-bind's template is stamped before the dom-bind element in the 1.x case.

Actual Results

The content of the dom-bind's template is stamped inside the dom-bind element but before the template in the 1.x case.

@kevinpschaaf
Copy link
Member

Fixed via #4537. Will be released in v1.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants