Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make error messages more verbose #4478

Closed
owencm opened this issue Mar 31, 2017 · 1 comment · Fixed by #4508
Closed

Make error messages more verbose #4478

owencm opened this issue Mar 31, 2017 · 1 comment · Fixed by #4508
Assignees
@sorvell
Labels
2.x p1

Comments

@owencm
Copy link

owencm commented Mar 31, 2017

Description

Some errors aren't very helpful. For example, when passing malformed JSON as a property I see:

"Polymer::Attributes: couldn`t decode Array as JSON"

but it would have been more helpful to know which string it tried to decode and failed, in this case "['Owen','Elizabeth']".

Preferred error message: "Polymer::Attributes: couldn`t decode Array as JSON: ['Owen','Elizabeth']"

Versions

  • Polymer: "2.0-preview"
@sorvell sorvell self-assigned this Apr 3, 2017
@sorvell sorvell added the p1 label Apr 3, 2017
@sorvell
Copy link
Contributor

sorvell commented Apr 3, 2017 •
edited
Loading

We endeavor to make error messages useful in general.

We'll go ahead and change this one and welcome other examples that could stand improvement.

@sorvell sorvell added the 2.x label Apr 3, 2017
sorvell pushed a commit that referenced this issue Apr 6, 2017
Fixes #4478 by adding a better warning for attributes that cannot des…
dba28c0 
…erialize from JSON.
@sorvell sorvell mentioned this issue Apr 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
2.x p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds a better warning for attributes that cannot deserialize from JSON Polymer/polymer
2 participants
@sorvell @owencm