Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible incorrect variable reference. #4445

Closed
coreyfarrell opened this issue Mar 18, 2017 · 2 comments
Closed

Possible incorrect variable reference. #4445

coreyfarrell opened this issue Mar 18, 2017 · 2 comments
Assignees
Labels

Comments

@coreyfarrell
Copy link
Contributor

Sorry if this is not a real bug. Current code at https://github.com/Polymer/polymer/blame/master/lib/utils/mixin.html#L54 checks for mixin.__id, then sets mixin.__dedupeId. Seems like the same property should be used all the time. This bug report is based purely on my belief that "this looks wrong", I have not seen it cause trouble in real life.

This code was originally added by @sorvell:

@dfreedm
Copy link
Member

dfreedm commented Mar 20, 2017

Yeah, that seems suspicious. Thanks!

@dfreedm dfreedm self-assigned this Mar 20, 2017
@dfreedm dfreedm added the p1 label Mar 20, 2017
@dfreedm
Copy link
Member

dfreedm commented Mar 20, 2017

The __dedupeId is set on mixin function creation, so the check doesn't matter.
The caching functionality also makes sure that any funky nesting of dedupingMixin will end in the same output class.
Since the check doesn't work anyway, I'll remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants