Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for applyAuthorStyles/resetStyleInheritance #425

Closed
ebidel opened this issue Feb 20, 2014 · 7 comments
Closed

Remove support for applyAuthorStyles/resetStyleInheritance #425

ebidel opened this issue Feb 20, 2014 · 7 comments

Comments

@ebidel
Copy link
Contributor

ebidel commented Feb 20, 2014

These properties are supported on Polymer(), but they're going away.

@ebidel
Copy link
Contributor Author

ebidel commented Mar 16, 2014

applyAuthorStyles was removed in googlearchive/polymer-dev@67ac33e.

resetStyleInheritance is being kept around for awhile longer in native SD because some customers were using it. We'll eventually need to remove. Closing for now.

@ebidel ebidel closed this as completed Mar 16, 2014
@addyosmani
Copy link
Member

I assume now would be a good time to also drop all refs to them in any boilerplate/tutorials we've put together in the past?

@ebidel
Copy link
Contributor Author

ebidel commented Mar 16, 2014

Yes, please. aAS was removed form the polymer docs and h5r articles.

@roydukkey
Copy link

Why was this removed? Is there an alternate way to stop parent document styles from bleeding into web components?

@ebidel
Copy link
Contributor Author

ebidel commented Jun 9, 2014

The spec discussion is here: https://www.w3.org/Bugs/Public/show_bug.cgi?id=23625

By default, Shadow DOM prevents parent document styles from bleeding into components. applyAuthorAuthor styles is the opposite. It allowed them in. The replacement for resetStyleInheritance is CSS all (https://developer.mozilla.org/en-US/docs/Web/CSS/all). That's not implemented yet in Chrome.

@roydukkey
Copy link

Humm. Okay. I don't know if this is expected, but html { color: red; } is applied to Shadow DOM. This was my original test and I noticed this wasn't functioning as I expected. Thanks!

@ebidel
Copy link
Contributor Author

ebidel commented Jun 9, 2014

color is an inheritable property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants